Re: Incorrectly reporting config errors

From: Adrian Klaver <adrian(dot)klaver(at)gmail(dot)com>
To: Thom Brown <thom(at)linux(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrectly reporting config errors
Date: 2014-01-21 18:42:29
Message-ID: 52DEBF95.2030008@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/21/2014 10:26 AM, Thom Brown wrote:
> Hi all,
>
> I'm getting a report of a config error when changing a config value
> that requires a restart:
>
> In postgresql.conf
>
> max_connections = 92
>
>
> (pg_ctl restart)
>
> postgres=# show max_connections ;
> max_connections
> -----------------
> 92
> (1 row)
>
>
> (Edit postgresql.conf so that max_connections = 93)
>
> (pg_ctl reload)
>
> Now the log file contains:
>
> 2014-01-21 18:14:53 GMT [28718]: [4-1] user=,db=,client= LOG:
> received SIGHUP, reloading configuration files
> 2014-01-21 18:14:53 GMT [28718]: [5-1] user=,db=,client= LOG:
> parameter "max_connections" cannot be changed without restarting the
> server
> 2014-01-21 18:14:53 GMT [28718]: [6-1] user=,db=,client= LOG:
> configuration file "/home/thom/Development/data/postgresql.conf"
> contains errors; unaffected changes were applied
>
> It doesn't contain errors. I changed the 92 to 93. If I restart, it
> doesn't complain, and there's nothing in the log about the config
> anymore.
>
> This seems to be the case for any parameter with a postmaster context.
>
> I can understand why it logs the message about it not changing without
> a restart, but the other one seems like a bug.

You wanted a change in a value, the change did not occur, hence an error.

>
> I've tested this on 9.3 and 9.4devel.
>
> Thom
>
>

--
Adrian Klaver
adrian(dot)klaver(at)gmail(dot)com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thom Brown 2014-01-21 18:59:35 Re: Incorrectly reporting config errors
Previous Message Simon Riggs 2014-01-21 18:41:50 Re: Hard limit on WAL space used (because PANIC sucks)