| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Marko Tiikkaja <marko(at)joh(dot)to> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new json funcs |
| Date: | 2014-01-18 20:38:42 |
| Message-ID: | 52DAE652.2050209@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/18/2014 12:34 PM, Marko Tiikkaja wrote:
> On 2014-01-17 03:08, Andrew Dunstan wrote:
>> In case anyone feels like really nitpicking, this version fixes some
>> pgindent weirdness due to an outdated typedef list in the previous
>> version.
>
> Is it possible for you to generate a diff that doesn't have all these
> unrelated changes in it (from a pgindent run, I presume)? I just read
> through three pagefuls and I didn't see any relevant changes, but I'm
> not sure I want to keep doing that for the rest of the patch.
>
>
>
This seems to be quite overstated. The chunks in the version 3 patch
that only contain pgindent effects are those at lines 751,771,866 and
1808 of json.c, by my reckoning. All the other changes are more than
formatting.
And undoing the pgindent changes and then individually applying all but
those mentioned above would take me a lot of time.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Tiikkaja | 2014-01-18 21:05:05 | Re: new json funcs |
| Previous Message | Tom Lane | 2014-01-18 20:26:24 | Re: [PATCH] Make various variables read-only (const) |