| From: | Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | David Fetter <david(at)fetter(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Jim Nasby <jim(at)nasby(dot)net> |
| Subject: | Re: CREATE TABLESPACE WITH |
| Date: | 2014-01-16 00:03:19 |
| Message-ID: | 52D721C7.9090901@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/15/2014 03:07 AM, Michael Paquier wrote:
> I just had a quick look at this patch, no testing at all.
Thank you for looking at it.
> I am seeing that regression tests are still missing here, they should be added in
> src/test/regress/input/tablespace.source.
New patch attached, with regression tests.
> Then, for the use of either
> WITH or SET... For example CREATE FUNCTION uses SET for a
> configuration parameter, and ALTER FUNCTION is consistent with that.
> So SET makes more sense to be consistent with CREATE TABLESPACE? This
> patch should not be modified once again as long as there are no more
> opinions though...
Based on your analysis of current behavior elsewhere, and the messier
patch with SET, I have switched my vote from ambivalent to preferring WITH.
--
Vik
| Attachment | Content-Type | Size |
|---|---|---|
| create_tablespace_with_v3.patch | text/x-diff | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Chinner | 2014-01-16 00:04:34 | Re: [Lsf-pc] Linux kernel impact on PostgreSQL performance |
| Previous Message | Dave Chinner | 2014-01-15 23:57:35 | Re: [Lsf-pc] Linux kernel impact on PostgreSQL performance |