Re: Case sensitive mode in windows build option

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Case sensitive mode in windows build option
Date: 2014-01-14 05:55:16
Message-ID: 52D4D144.4060701@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/14/2014 11:49 AM, Dilip kumar wrote:
>
>
> As per current behavior if user want to build in debug mode in windows,
> then he need to give debug in capital letters (DEBUG),
>
> I think many user will always make mistake in giving this option, in my
> opinion we can make it case insensitive.

The idea seems reasonable, the implementation does not. You've changed
the meaning rather more than making it case insensitive.

Use the Perl 'lc' function to compare a lower-cased input instead.

http://perldoc.perl.org/functions/lc.html

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-01-14 06:16:11 Re: Performance Improvement by reducing WAL for Update Operation
Previous Message Dilip kumar 2014-01-14 03:49:36 Case sensitive mode in windows build option