| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Pavel Raiskup <praiskup(at)redhat(dot)com> |
| Cc: | psql-odbc <pgsql-odbc(at)postgresql(dot)org> |
| Subject: | Re: Static analysis fix request |
| Date: | 2014-01-06 10:14:58 |
| Message-ID: | 52CA8222.4000208@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-odbc |
On 01/06/2014 11:00 AM, Pavel Raiskup wrote:
> * Attached fix for overrun. This is imo worth fixing.
>
> * Attached added gcc & Coverity warnings (added between 9.2.1 and 9.3.1)
Ironically, I changed the code the way it is now, per previous static
analyzer report. It was off by even more before.
And I think it's still wrong :-). The code that follows expects the
prefix[] array to be terminated by a NULL entry.
That code is really difficult to read, and hence difficult to get
correct. Since we've already been burned twice by it, let's make it less
error-prone. How about the attached? Does that look correct to you?
(Perhaps we should just rip out the prefix stuff, though. It's only
there to support pre-7.3 servers)
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| fix-prefixes-and-table_types-loops-2.patch | text/x-diff | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Raiskup | 2014-01-06 14:48:01 | Re: Static analysis fix request |
| Previous Message | Pavel Raiskup | 2014-01-06 09:00:41 | Static analysis fix request |