Re: CREATE TABLESPACE SET

From: Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CREATE TABLESPACE SET
Date: 2013-12-26 17:33:20
Message-ID: 52BC6860.2070708@dalibo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/26/2013 06:10 PM, David Fetter wrote:
> On Tue, Dec 24, 2013 at 07:25:01PM +0100, Vik Fearing wrote:
>> I was recently annoyed that I had to do
>>
>> CREATE TABLESPACE x LOCATION y;
>> ALTER TABLESPACE x SET (random_page_cost = z);
>>
>> The attached patch is a quick n' dirty extension to allow the SET
>> directly on the CREATE statement.
>>
>> CREATE TABLESPACE x LOCATION y SET (random_page_cost = z);
> That should probably be WITH instead of SET for consistency with other
> similar DDL.

It would make a simpler patch, too, but I wanted to be consistent with
ALTER TABLESPACE. I have no firm opinion on the subject, so I'll switch
it to WITH if no one else says anything.

--
Vik

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Adrian Klaver 2013-12-26 18:13:58 Re: pg_upgrade & tablespaces
Previous Message David Fetter 2013-12-26 17:10:57 Re: CREATE TABLESPACE SET