From: | "Dr(dot) Andreas Kunert" <kunert(at)cms(dot)hu-berlin(dot)de> |
---|---|
To: | Marko Kreen <markokr(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Feature request: Logging SSL connections |
Date: | 2013-12-06 13:53:27 |
Message-ID: | 52A1D6D7.3080309@cms.hu-berlin.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>> Anything else missing?
>
> Functionally it's fine now, but I see few style problems:
>
> - "if (port->ssl > 0)" is wrong, ->ssl is pointer. So use just
> "if (port->ssl)".
> - Deeper indentation would look nicer with braces.
> - There are some duplicated message, could you restructure it so that
> each message exists only once.
New version is attached. I could add braces before and after the
ereport()-calls too, but then I need two more #ifdefs to catch the
closing braces.
--
---------------------------------------------------------------------------
____ ______ ____
Dr. Andreas Kunert / __/ / / / __/
HU-Berlin, ZE Rechenzentrum (CMS) / /_ / / / / __\\
www.hu-berlin.de/~kunert /___/ /_/_/_/ /___/
---------------------------------------------------------------------------
Attachment | Content-Type | Size |
---|---|---|
log.patch | text/x-patch | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | MauMau | 2013-12-06 14:12:57 | Re: Re: [RFC] Shouldn't we remove annoying FATAL messages from server log? |
Previous Message | MauMau | 2013-12-06 13:38:53 | Re: Re: [RFC] Shouldn't we remove annoying FATAL messages from server log? |