Re: Easily reading debug_print_plan

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Easily reading debug_print_plan
Date: 2013-11-20 23:59:09
Message-ID: 528D4CCD.90306@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/20/2013 10:36 PM, Tom Lane wrote:
> Craig Ringer <craig(at)2ndquadrant(dot)com> writes:
>> I'm spending a lot of time staring at parse and plan trees at the
>> moment, and I'm finding reading them rather cumbersome.
>
> Is there a particular reason you're doing that rather than looking at
> EXPLAIN output? Only the latter is meant to be at all user-friendly.

Because I'm working on updatable security_barrier views using the
approach outlined to the list earlier. EXPLAIN really doesn't do the
trick for working on the guts of the rewriter.

>> The same representation is used for storing rules. So it can't be
>> changed for BC reasons and compactness/performance.
>
> We could in principle change to a different text representation for
> stored rules. Compactness would be an issue if it were materially
> bigger than the existing formatting, but offhand it seems like JSON
> is morally equivalent to what we do now, no?
>
> If you think this is worthwhile, you might care to take a look at
> outfuncs.c/readfuncs.c and figure out what it'd take to switch to
> json-compatible formatting.

I do think it might be worthwhile at some point, but once I remembered
it was about more than just debug_print_ output - that DB performance is
impacted - I realised it was not a topic for a quick and simple change.
Benchmarking required, etc.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2013-11-21 00:01:37 Re: Can we trust fsync?
Previous Message Andres Freund 2013-11-20 23:57:28 Re: Data corruption issues using streaming replication on 9.0.14/9.2.5/9.3.1