Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT

From: "Zubkovsky, Sergey" <Sergey(dot)Zubkovsky(at)transas(dot)com>
To: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Gregory Stark" <stark(at)enterprisedb(dot)com>, <pgsql-patches(at)postgresql(dot)org>, "Magnus Hagander" <magnus(at)hagander(dot)net>
Subject: Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT
Date: 2008-04-29 12:18:25
Message-ID: 528853D3C5ED2C4AA8990B504BA7FB850658BA5C@sol.transas.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Hi,

Here is the patch.
Check it, please.

Locations of the added files:
src\include\port\win32_msvc\sys\stat.inl
src\port\stat_pg_fixed.c

Thank you.

-----Original Message-----
From: Andrew Dunstan [mailto:andrew(at)dunslane(dot)net]
Sent: Saturday, March 29, 2008 4:18 PM
To: Zubkovsky, Sergey
Cc: Tom Lane; Alvaro Herrera; Gregory Stark;
pgsql-hackers(at)postgresql(dot)org; Magnus Hagander
Subject: Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT

Zubkovsky, Sergey wrote:
>
> In the prepared custom build of PG 8.3.1 the native MSVC's stat() was
rewrote by adding GetFileAttributesEx() to correct stat's st_size value.
> I had seen that a result of MSVC's stat() and a result of
GetFileAttributesEx() may be differ by the file size values at least.
>
> The most important thing is the test in the original post
> ( http://archives.postgresql.org/pgsql-docs/2008-03/msg00041.php )
> doesn't reproduce any inconsistence now.
> All work fine.
>
> This was tested on my WinXP SP2 platform but I suppose it will work on
any NT-based OS.
>
>
>

If you have a patch, please send it to the -patches list.

cheers

andrew

Attachment Content-Type Size
Mkvcbuild.pm.patch application/octet-stream 825 bytes
stat_pg_fixed.c application/octet-stream 3.1 KB
stat.inl application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-04-29 12:18:52 Re: Proposed patch - psql wraps at window width
Previous Message Bruce Momjian 2008-04-29 12:17:26 Re: [HACKERS] Proposed patch - psql wraps at window width

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2008-04-29 12:53:34 Re: [HACKERS] [DOCS] pg_total_relation_size() and CHECKPOINT
Previous Message Bruce Momjian 2008-04-29 12:17:26 Re: [HACKERS] Proposed patch - psql wraps at window width