| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Turning recovery.conf into GUCs |
| Date: | 2013-11-15 21:11:46 |
| Message-ID: | 52868E12.6050803@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/15/2013 06:38 AM, Jaime Casanova wrote:
>> > Please check for compiler warnings in pg_basebackup:
>> >
>> > pg_basebackup.c:1109:1: warning: ‘escapeConnectionParameter’ defined but not used [-Wunused-function]
>> > pg_basebackup.c:1168:1: warning: ‘escape_quotes’ defined but not used [-Wunused-function]
>> >
> those are functions that are no longer used but Josh considered they
> could become useful before release.
> i can put them inside #ifdef _NOT_USED_ decorations or just remove
> them now and if/when we find some use for them re add them
Wait, which Josh? Not me ...
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2013-11-15 21:12:16 | Re: additional json functionality |
| Previous Message | Thom Brown | 2013-11-15 21:06:30 | Re: postgres_fdw, remote triggers and schemas |