Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation
Date: 2013-11-10 21:39:21
Message-ID: 527FFD09.3050904@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 11/10/2013 04:16 PM, Peter Geoghegan wrote:
> On Sun, Nov 10, 2013 at 1:07 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'd argue the opposite --- the existing shell-script version is entirely
>> useless to developers running on Windows, while they could use a Perl
>> version. Also, we've pretty much locked in the assumption that developers
>> will have Perl.
> +1.
>

It might be a bit more portable if we replaced the shebang lines on perl
scripts with

#!/bin/env perl

That's probably worth considering. MSVC users would still have to call
"perl scriptname" or possibly "\path\to\perl scriptname", but I think
that's OK, and they will have to do that anyway.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2013-11-10 22:51:06 Re: pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag
Previous Message Peter Geoghegan 2013-11-10 21:16:24 Re: [COMMITTERS] pgsql: Replace duplicate_oids with Perl implementation

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2013-11-10 22:11:59 Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist
Previous Message Tom Lane 2013-11-10 21:28:27 Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist