| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Kevin Grittner <kgrittn(at)ymail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: alter_table regression test problem |
| Date: | 2013-11-07 15:12:15 |
| Message-ID: | 527BADCF.4020807@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/07/2013 09:59 AM, Andres Freund wrote:
> On 2013-11-07 06:49:58 -0800, Kevin Grittner wrote:
>> It's up to the committer whether to indent
>> after review and make both substantive and whitespace changes
>> together, but I have definitely seen those done separately, or even
>> left for the next global pgindent run to fix.
> Hm. I don't remember many such cases and I've just looked across the git
> history and i didn't really find anything after
> a04161f2eab55f72b3c3dba9baed0ec09e7f633f, but that was back when
> individuals couldn't run pgindent because of the typedefs file.
>
Perhaps we need more frequent pgindent runs.
both patch and git-apply have options to ignore whitespace changes.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2013-11-07 15:56:41 | Comment - uniqueness of relfilenode |
| Previous Message | Tom Lane | 2013-11-07 15:10:34 | Re: alter_table regression test problem |