Re: git diff --check whitespace checks, gitattributes

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: git diff --check whitespace checks, gitattributes
Date: 2013-11-06 13:38:20
Message-ID: 527A464C.4020407@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/5/13, 10:31 PM, Tom Lane wrote:
> I always (well, almost always) do git diff --check, so making it stronger
> sounds good to me. But it sounds like this still leaves it to the
> committer to remember to run it. Can we do anything about that?

Sure, you could install an update hook on the server. I'm generally not
in favor of such things, but that's a separate discussion. Build
servers could also do this checking.

> Maybe we should think about fixing psql to not generate that whitespace.

Not easy, see
http://www.postgresql.org/message-id/1285093687.5468.18.camel@vanquo.pezone.net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-11-06 13:39:26 Re: git diff --check whitespace checks, gitattributes
Previous Message Robert Haas 2013-11-06 13:15:59 Re: better atomics