| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Sutou Kouhei <kou(at)clear-code(dot)com>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
| Subject: | Re: confusing / inefficient "need_transcoding" handling in copy |
| Date: | 2024-02-06 17:51:48 |
| Message-ID: | 526893.1707241908@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Feb 05, 2024 at 06:05:04PM -0800, Andres Freund wrote:
>> I haven't yet dug into the code history. One guess is that this should only
>> have been set this way for COPY FROM.
> Looking the git history, this looks like an oversight of c61a2f58418e
> that has added the condition on pg_database_encoding_max_length(), no?
> Adding Tom and Ishii-san, even if this comes from 2005.
Yeah, back in 8.1 that code was applied for both directions, but
probably it should have enforced validation for same-encoding
cases only for COPY FROM.
It looks like now we have a mess, because the condition was copied
verbatim into copyto.c but not copyfrom.c. Aren't we failing to
validate encoding in this case in COPY FROM, which is where we
actually need to?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amonson, Paul D | 2024-02-06 18:16:23 | RE: Popcount optimization using AVX512 |
| Previous Message | Bharath Rupireddy | 2024-02-06 17:32:33 | Re: Introduce XID age and inactive timeout based replication slot invalidation |