| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Satoshi Nagayasu <snaga(at)uptime(dot)jp>, Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Dave Rolsky <autarch(at)urth(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist |
| Date: | 2013-10-10 16:54:23 |
| Message-ID: | 5256DBBF.8010605@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 09/19/2013 06:12 PM, Pavel Stehule wrote:
>
>
> 2013/9/16 Satoshi Nagayasu <snaga(at)uptime(dot)jp <mailto:snaga(at)uptime(dot)jp>>
>
>
>
> I'm looking at this patch, and I have a question here.
>
> Should "DROP TRIGGER IF EXISTS" ignore error for non-existing trigger
> and non-existing table? Or just only for non-existing trigger?
>
>
> My opinion is so, both variants should be ignored - it should be fully
> fault tolerant in this use case.
>
>
This thread seems to have gone cold, but I'm inclined to agree with
Pavel. If the table doesn't exist, neither does the trigger, and the
whole point of the 'IF EXISTS' variants is to provide the ability to
issue DROP commands that don't fail if their target is missing.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2013-10-10 20:05:50 | Re: BUG #8467: Slightly confusing pgcrypto example in docs |
| Previous Message | Andrius Di | 2013-10-10 14:18:27 | error |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2013-10-10 16:59:39 | Re: Auto-tuning work_mem and maintenance_work_mem |
| Previous Message | Bruce Momjian | 2013-10-10 16:45:31 | Re: Auto-tuning work_mem and maintenance_work_mem |