From: | Josh Berkus <josh(at)agliodbs(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Prevent pg_basebackup -Fp -D -? |
Date: | 2013-10-03 01:10:39 |
Message-ID: | 524CC40F.1000506@agliodbs.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 10/02/2013 05:47 PM, Michael Paquier wrote:
> On Wed, Oct 2, 2013 at 11:31 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Right now, if you use
>>
>> pg_basebackup -Ft -D -
>>
>> you get a tarfile, written to stdout, for redirection.
>>
>> However, if you use:
>>
>> pg_basebackup -Fp -D -
>>
>> you get a plaintext (unpackaged) backup, in a directory called "-".
>>
>> I can't think of a single usecase where this is a good idea. Therefor,
>> I would suggest we simply throw an error in this case, instead of
>> creating the directory. Only for the specific case of specifying
>> exactly "-" as a directory.
>>
>> Comments?
I can see fixing this going forwards, but it doesn't seem worth
backpatching.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2013-10-03 04:50:57 | Re: Prevent pg_basebackup -Fp -D -? |
Previous Message | Michael Paquier | 2013-10-03 00:47:18 | Re: Prevent pg_basebackup -Fp -D -? |