From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | Boszormenyi Zoltan <zb(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at> |
Subject: | Re: Build system problem in 8.3.x |
Date: | 2009-08-27 16:15:01 |
Message-ID: | 5249.1251389701@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
>> *** src/Makefile.port.old 2009-08-27 10:56:46.000000000 +0200
>> --- src/Makefile.port 2009-08-27 10:56:46.000000000 +0200
>> ***************
>> *** 11,16 ****
>> endif
>>
>> %.so: %.o
>> ! $(CC) -shared -o $@ $<
>>
>> sqlmansect = 7
>> --- 11,16 ----
>> endif
>>
>> %.so: %.o
>> ! $(CC) $(CFLAGS) -shared -o $@ $<
>>
>> sqlmansect = 7
> I guess we should change that rule to use $(LD) instead of $(CC), and
> include $(LDFLAGS) in the rules that build SUBSYS.o. Or maybe there's a
> reason they are what they are, I don't know. (SUBSYS.o's are gone in 8.4
> anyway)
Those rules are used to build .so's, not SUBSYS.o's. I see that this
change is already applied to Makefile.linux in HEAD, but I'm not sure
it's worth back-patching by itself. We know that on Darwin, which is
where the most work has been done on cross-arch/multiarch builds, you
really need the SUBSYS.o-ectomy as well to make multiarch builds simple.
And we're *not* back-patching that.
I'm inclined to say that making this workable is an 8.4 feature and
you should use 8.4 if you need it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-08-27 16:17:19 | Re: pretty print viewdefs |
Previous Message | Kevin Grittner | 2009-08-27 16:10:45 | Re: [pgsql-hackers] Daily digest v1.9418 (15 messages) |