Re: pgbench - adding pl/pgsql versions of tests

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Hannu Krosing <hannuk(at)google(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dimitri Fontaine <dim(at)tapoueh(dot)org>
Subject: Re: pgbench - adding pl/pgsql versions of tests
Date: 2023-08-16 08:06:09
Message-ID: 52432287-b496-abd3-edc-4beddbc051f0@mines-paristech.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Nathan,

>> I'm unclear about what variety of scripts that could be provided given the
>> tables made available with pgbench. ISTM that other scenari would involve
>> both an initialization and associated scripts, and any proposal would be
>> bared because it would open the door to anything.
>
> Why's that?

Just a wild guess based on 19 years of occasional contributions to pg and
pgbench in particular:-)

> I'm not aware of any project policy that prohibits such enhancements to
> pgbench.

Attempts in extending pgbench often fall under "you can do it outside (eg
with a custom script) so there is no need to put that in pgbench as it
would add to the maintenance burden with a weak benefit proven by the fact
that it is not there already".

> It might take some effort to gather consensus on a proposal like this,
> but IMHO that doesn't mean we shouldn't try.

Done it in the past. Probably will do it again in the future:-)

> If the prevailing wisdom is that we shouldn't add more built-in scripts
> because there is an existing way to provide custom ones, then it's not
> clear that we should proceed with $SUBJECT, anyway.

I'm afraid there is that argument. I do not think that this policy is good
wrt $SUBJECT, ISTM that having an easy way to test something with a
PL/pgSQL function would help promote the language by advertising/showing
the potential performance benefit (or not, depending). Just one function
would be enough for that.

--
Fabien.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2023-08-16 09:09:02 regexp_replace weirdness amounts to a bug?
Previous Message Peter Eisentraut 2023-08-16 08:02:11 Re: cataloguing NOT NULL constraints