From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
Cc: | pgsql-www(at)postgresql(dot)org |
Subject: | Re: buildfarm git references pointing at github? |
Date: | 2017-03-14 15:07:45 |
Message-ID: | 5242.1489504065@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-www |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On 03/14/2017 10:32 AM, Tom Lane wrote:
>> +1 for commitdiff, that's pretty much always the form of the page I want
>> to see.
> Done.
Thanks for changing that, it's definitely helpful.
I'm a bit confused about the links for the "files changed this run"
list. What they seem to be now is pointers to the last commit that
changed each file. I might be misremembering, but I thought they
had been links to the individual files in our git tree. As long
as we're fooling around here, it seems like links to the per-file
history logs would be convenient; eg instead of
which is the link being offered right now for
src/backend/optimizer/plan/createplan.c in recent runs, perhaps
That particular display is useful since it's easy to get to either
the raw file contents ("blob") or the relevant commitdiffs from there.
However, fooling with it, it seems that the blob links don't get offered
unless the "h=" hash is the file's hash, not the commit's hash. (gitweb
bug?) That might make it too hard to do, dunno. A close second in
usefulness would be to use the commit's hash,
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2017-03-14 15:14:47 | Re: buildfarm git references pointing at github? |
Previous Message | Andrew Dunstan | 2017-03-14 14:55:11 | Re: buildfarm git references pointing at github? |