Re: Location for pgstat.stat

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Location for pgstat.stat
Date: 2008-08-04 15:37:36
Message-ID: 5238.1217864256@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Attached is a patch that implements this. I went with the option of just
> storing it in a temporary directory that can be symlinked, and not
> bothering with a GUC for it. Comments? (documentation updates are also
> needed, but I'll wait with those until I hear patch comments :-P)

Looks alright in a fast once-over (I didn't test it). Two comments:
Treating the directory as something to create in initdb means you'll
need to bump catversion when you apply it. I'm not sure where you are
planning to document, but there should at least be a mention in the
"database physical layout" chapter, since that's supposed to enumerate
all the subdirectories of $PGDATA.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-08-04 15:39:03 Re: DROP DATABASE always seeing database in use
Previous Message Andrew Dunstan 2008-08-04 15:35:54 Re: DROP DATABASE always seeing database in use