| From: | Marko Tiikkaja <marko(at)joh(dot)to> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Updatable view columns |
| Date: | 2013-09-16 20:14:47 |
| Message-ID: | 523766B7.8040007@joh.to |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Dean,
First of all, thanks for working on this!
The patch compiles and applies fine (though with offsets). The feature
is in the SQL standard, and further improves an existing feature.
Some stuff I've spotted and fixed in the attached patch (hope you don't
mind, thought it'd be easier to just fix these rather than describing
them in email):
- Some typos I've spotted in some of the comments
- Fixed escaping of _ in regression tests
Other than these, the patch looks good to me. Will wait for your
thoughts and an updated patch before marking ready for committer.
Regards,
Marko Tiikkaja
| Attachment | Content-Type | Size |
|---|---|---|
| updatable_views_typos.patch | text/plain | 7.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2013-09-16 20:31:37 | Re: [PATCH] Add use of asprintf() |
| Previous Message | Jeff Janes | 2013-09-16 19:55:09 | Re: git apply vs patch -p1 |