Sure Aditya, appreciates your feedback.
I will be doing a cross check with below requirements & get back with updates.
Thanks !
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
edbpostgres.com
From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Date: Thursday, 6 August 2020 at 6:04 PM
To: Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: Code coverage report generation for JS files
Hi Pramod,
The patch looks good to me except:
1) Remove commented code.
2) Make coverage report optional using command line flag --reporters. Add a new cmd in yarn - test:karma-coverage.
3) Add the new coverage directory to .gitignore.
On Thu, Aug 6, 2020 at 4:59 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
Hi Aditya
Please review it.
On Thu, Aug 6, 2020 at 12:12 PM Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com> wrote:
Hi,
Please find updated patch for below changes:
Updated path for test files to module/test dir (As suggested by @Ashesh & @Nil)
Added exclusion expression for test cases
Added Lcov report generation along with html for sonarqube report combination
Please have a review & do let me know if any changes/suggestions.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
edbpostgres.com
From: Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
Date: Wednesday, 5 August 2020 at 4:45 PM
Subject: Re: Code coverage report generation for JS files
Missed Screenshot with previous email.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
edbpostgres.com
From: Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
Date: Wednesday, 5 August 2020 at 4:44 PM
Subject: Code coverage report generation for JS files
Hi Team,
As recent updates have added ability to generate code coverage report for all the JS files.
Where had added two new packages as below:
istanbul-instrumenter-loader
karma-coverage
Steps to generate report:
Apply attached patch
Do - ‘npm install’
Run – ‘yarn run test:karma’
It has below type of output formats supported:
Html
Lcov
Cobertura
Lcovonly
Teamcity
Text
Text-summery
All the output files will be generated & stored in ‘root_dir/coverage’ folder .
Please do let me know your thoughts or suggestion if any.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
edbpostgres.com
--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
