| From: | Tarvi Pillessaar <tarvip(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Detail part for still waiting for lock log message |
| Date: | 2013-08-26 12:18:34 |
| Message-ID: | 521B479A.2020502@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fixed patch attached.
Regards,
Tarvi Pillessaar
On 24.08.2013 17:58, Peter Eisentraut wrote:
> On Tue, 2013-08-20 at 19:21 +0300, Tarvi Pillessaar wrote:
>> About patch:
>> Patch is tested against 9.2.4.
>> I was not sure that i should check if the lock holder's proclock was
>> found (as lock holder's proclock should be always there), check is there
>> to be on the safe side, but maybe it's unnecessary.
>> If it's not needed then fallback to old behavior (logging without
>> detail) is not needed as well.
>> And yes, i know that the lock holding time is not actually correct and
>> it actually shows milliseconds since transaction start.
>>
> Please fix this compiler warning:
>
> proc.c: In function ‘ProcSleep’:
> proc.c:1258:6: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| still_waiting_for_lock-v2.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleg Bartunov | 2013-08-26 12:26:40 | Re: Hstore: Query speedups with Gin index |
| Previous Message | Hannu Krosing | 2013-08-26 12:15:49 | Re: Backup throttling |