Re: GSOC13 proposal - extend RETURNING syntax

2013-08-20 17:30 keltezéssel, Karol Trzcionka írta:
> W dniu 20.08.2013 16:47, Karol Trzcionka pisze:
>> Thank you for the review and tests. New version introduce a lot of
>> improvements:
>> - Fix regression test for view (wrong table_name)
>> - Add regression test for inheritance
>> - Delete hack in initsplan.c (now we ignore all RTE_BEFORE) - the
>> uninitialized issue
>> - Revert changing varno in add_vars_to_targetlist
>> - Add all "before" variables to targetlist
>> - Avoid adding variables to slot for AFTER.
>> - Treat varnoold like a flag - prevent from adjustment if RTE_BEFORE
>> - All before/after are now set on OUTER_VAR
>> - Rename fix_varno_varattno to bind_returning_variables
>> - Add comment about bind_returning_variables
>> - Remove unneeded code in fix_join_expr_mutator (it was changing varno
>> of RTE_BEFORE - now there is not any var with varno assigned to it)
> I've just realized the prepare_returning_before() is unneeded right now
> so I've removed it. Version 7, hopefully the last. ;)

Here's a new one, for v7:

setrefs.c: In function ‘set_plan_refs’:
setrefs.c:2001:26: warning: ‘before_index’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
bind_returning_variables(rlist, before_index, after_index);
^
setrefs.c:1957:21: note: ‘before_index’ was declared here
int after_index=0, before_index;
^

Best regards,
Zoltán Böszörményi

> Regards,
> Karol Trzcionka
>
>

--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/