Re: Fix compiler warnings on 64-bit Windows

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix compiler warnings on 64-bit Windows
Date: 2020-02-17 08:44:20
Message-ID: 51ea19db-8094-5cc7-658b-f6f2efcc2626@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-02-14 15:52, Tom Lane wrote:
> Yeah, I think that the C99 requirement has obsoleted a number of configure
> tests and related hackery in c.h. We just haven't got round to cleaning
> that up yet.
>
> BTW: I'm still concerned about the possibility of the C library being
> less than C99. The model that was popular back then, and which still
> exists on e.g. gaur, was that you could install a C99 *compiler* on
> a pre-C99 system, and the compiler would bring its own standard header
> files as necessary. While I don't have the machine booted up to check,
> I'm pretty sure that gaur's <stdint.h> is being supplied by the gcc
> installation not directly from /usr/include. On the other hand, that
> compiler installation is still dependent on the vendor-supplied libc.

Yeah, stdint.h belongs to the compiler, whereas intttypes.h belongs to
the C library. So if we require a C99 compiler we can get rid of all
tests and workarounds for stdint.h missing. Patch attached.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Require-stdint.h.patch text/plain 7.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-02-17 08:52:46 Re: small improvement of the elapsed time for truncating heap in vacuum
Previous Message Asif Rehman 2020-02-17 08:39:08 Re: WIP/PoC for parallel backup