Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements

From: Karol Trzcionka <karlikt(at)gmail(dot)com>
To: Fabrízio de Royes Mello <fabrizio(at)timbira(dot)com(dot)br>
Cc: Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to add support of "IF NOT EXISTS" to others "CREATE" statements
Date: 2013-07-24 17:49:04
Message-ID: 51F01390.60901@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,
patch works fine but is there any reason to comparing each ifNotExists
in different way?
i.e.
ProcedureCreate
if (!ifNotExists)
...
else
{
...
return
}
----
TypeCreate
if (ifNotExists)
{
...
return
}
...
---
Shouldn't it be more consistent?
Regards,
Karol

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2013-07-24 17:50:09 Re: Review: UNNEST (and other functions) WITH ORDINALITY
Previous Message Tom Lane 2013-07-24 17:48:23 Re: [GENERAL] Insert result does not match record count