Re: enum-ify resource manager's xl_info values

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: enum-ify resource manager's xl_info values
Date: 2013-07-22 20:15:40
Message-ID: 51ED92EC.7070305@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/22/13 7:21 AM, Andres Freund wrote:
> Would somebody object to making the rmgr's invo value #defines like:

I'm suspicious of enums that are assigned specific values. Enums should
stand by themselves, they shouldn't be a symbolic layer on top of some
other numbering or bit-fiddling scheme.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2013-07-22 20:21:37 Re: new "row-level lock" error messages
Previous Message Andres Freund 2013-07-22 20:01:59 Re: small typo in src/backend/access/transam/xlog.c