From: | Mark Kirkwood <mark(dot)kirkwood(at)catalyst(dot)net(dot)nz> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org, Michael Meskes <meskes(at)postgresql(dot)org> |
Subject: | Re: [9.4 CF 1] The Commitfest Slacker List |
Date: | 2013-07-04 08:08:57 |
Message-ID: | 51D52D99.5070906@catalyst.net.nz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 04/07/13 10:43, Robert Haas wrote:
> And
> people who submit patches for review should also review patches: they
> are asking other people to do work, so they should also contribute
> work.
>
I think that is an overly simplistic view of things. People submit
patches for a variety of reasons, but typically because they think the
patch will make the product better (bugfix or new functionality). This
is a contribution in itself, not a debt.
Now reviewing is performed to ensure that submitted code is *actually*
going to improve the product.
Both these activities are volunteer work - to attempt to tie them
together forceably is unusual to say the least. The skills and
experience necessary to review patches are considerably higher than
those required to produce patches, hence the topic of this thread.
Now I do understand we have a shortage of reviewers and lots of patches,
and that this *is* a problem - but what a wonderful problem...many open
source projects would love to be in this situation!!!
Regards
Mark
From | Date | Subject | |
---|---|---|---|
Next Message | Dean Rasheed | 2013-07-04 08:15:08 | Re: Review: UNNEST (and other functions) WITH ORDINALITY |
Previous Message | Hari Babu | 2013-07-04 08:01:52 | Re: Review: Patch to compute Max LSN of Data Pages |