Re: Kudos for Reviewers -- straw poll

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Rodrigo Gonzalez <rjgonzale(dot)lists(at)gmail(dot)com>, Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Kudos for Reviewers -- straw poll
Date: 2013-06-26 19:12:44
Message-ID: 51CB3D2C.60900@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/26/2013 12:02 PM, Alvaro Herrera wrote:
> See the entry for foreign key locks:
>
> Prevent non-key-field row updates from locking foreign key rows (Álvaro
> Herrera, Noah Misch, Andres Freund, Alexander Shulgin, Marti Raudsepp)
>
> I am the author of most of the code, yet I chose to add Noah and Andres
> because they contributed a huge amount of time to reviewing the patch,
> and Alex and Marti because they submitted some code. They are all
> listed as coauthors, which seems a reasonable compromise to me.

What about the idea that reviewers who do code revision work, like in
your FK patch, get listed after the original patch author with the
patch, and reviewers do more lightweight reviews get listed at the
bottom of the release notes? Seems fair to me.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2013-06-26 19:19:01 Re: Add more regression tests for dbcommands
Previous Message Josh Berkus 2013-06-26 19:10:36 Re: Add more regression tests for CREATE OPERATOR