Re: Change authentication error message (patch)

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Markus Wanner <markus(at)bluegap(dot)ch>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Change authentication error message (patch)
Date: 2013-06-19 20:27:39
Message-ID: 51C2143B.3060404@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 06/19/2013 01:18 PM, Markus Wanner wrote:

>> "Authentication failed or password has expired for user \"%s\""
>>
>> Authentication failed covers any combination of a username/password
>> being wrong and obviously password expired covers the other.
>
> Works for me. Considering the password to be the thing that expires
> (rather than the account) is probably more accurate as well.

It is also how it is worded in the docs (which is why I used it). Patch
below.

JD

diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c
index 415b614..f129fe1 100644
--- a/src/backend/libpq/auth.c
+++ b/src/backend/libpq/auth.c
@@ -270,7 +270,7 @@ auth_failed(Port *port, int status)
break;
case uaPassword:
case uaMD5:
- errstr = gettext_noop("password authentication
failed for user \"%s\"");
+ errstr = gettext_noop("Authentication failed or
password has expired for user \"%s\"");
/* We use it to indicate if a .pgpass password
failed. */
errcode_return = ERRCODE_INVALID_PASSWORD;
break;

--
Command Prompt, Inc. - http://www.commandprompt.com/ 509-416-6579
PostgreSQL Support, Training, Professional Services and Development
High Availability, Oracle Conversion, Postgres-XC, @cmdpromptinc
For my dreams of your image that blossoms
a rose in the deeps of my heart. - W.B. Yeats

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2013-06-19 20:47:59 Re: [PATCH] Remove useless USE_PGXS support in contrib
Previous Message Kevin Grittner 2013-06-19 20:22:32 FP precision