Change authentication error message (patch)

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Change authentication error message (patch)
Date: 2013-06-16 16:02:34
Message-ID: 51BDE19A.9020106@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello,

Instead of pushing extra info to the logs I decided that we could
without giving away extra details per policy. I wrote the error message
in a way that tells the most obvious problems, without admitting to any
of them. Please see attached:

diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c
index 415b614..a775534 100644
--- a/src/backend/libpq/auth.c
+++ b/src/backend/libpq/auth.c
@@ -270,7 +270,7 @@ auth_failed(Port *port, int status)
break;
case uaPassword:
case uaMD5:
- errstr = gettext_noop("password authentication
failed for user \"%s\"");
+ errstr = gettext_noop("password, username or
password expiry failed for user \"%s\"");
/* We use it to indicate if a .pgpass password
failed. */
errcode_return = ERRCODE_INVALID_PASSWORD;
break;

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Cédric Villemain 2013-06-16 16:20:27 Re: [PATCH] Remove useless USE_PGXS support in contrib
Previous Message Heikki Linnakangas 2013-06-16 15:23:20 Re: In progress INSERT wrecks plans on table