| From: | Greg Smith <greg(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Jon Nelson <jnelson+pgsql(at)jamponi(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |
| Date: | 2013-05-30 10:55:16 |
| Message-ID: | 51A73014.4040908@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/30/13 6:49 AM, Robert Haas wrote:
> On Wed, May 29, 2013 at 10:42 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> So we don't even know whether we can read. I think that means we need to
>> zero the file anyway...
>
> Surely this is undue pessimism.
There have been many occasions where I've found the Linux kernel
defining support for POSIX behavior with a NOP stub that basically says
"we should make this work one day". I don't know whether the fallocate
code is one of those or a fully implemented call. Based on that
history, until I see a reader that validates the resulting files are
good I have to assume they're not.
--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-05-30 11:13:13 | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |
| Previous Message | Robert Haas | 2013-05-30 10:49:42 | Re: fallocate / posix_fallocate for new WAL file creation (etc...) |