Re: erroneous restore into pg_catalog schema

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Subject: Re: erroneous restore into pg_catalog schema
Date: 2013-05-13 17:32:24
Message-ID: 519123A8.2090305@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.05.2013 19:59, Robert Haas wrote:
> On Mon, May 13, 2013 at 12:35 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I wrote:
>>> Another way to fix that inconsistency is to consider that
>>> allow_system_table_mods should gate table creations not just drops in
>>> pg_catalog. I'm not real sure why this wasn't the case all along ...
>>
>> Uh, scratch that last comment: actually, allow_system_table_mods *did*
>> gate that, in every existing release. I bitched upthread about the fact
>> that this was changed in 9.3, and did not hear any very satisfactory
>> defense of the change.
>
> It disallowed it only for tables, and not for any other object type.
> I found that completely arbitrary. It's perfectly obvious that people
> want to be able to create objects in pg_catalog; shall we adopt a rule
> that you can put extension there, as long as those extensions don't
> happen to contain tables? That is certainly confusing and arbitrary.

Makes sense to me, actually. It's quite sensible to put functions,
operators, etc. in pg_catalog. Especially if they're part of an
extension. But I can't think of a good reason for putting a table in
pg_catalog. Maybe some sort of control data for an extension, but seems
like a kludge. Its contents wouldn't be included in pg_dump, for example.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-05-13 17:40:57 Re: erroneous restore into pg_catalog schema
Previous Message Tom Lane 2013-05-13 17:27:34 Re: erroneous restore into pg_catalog schema