Re: Commit subject line

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Commit subject line
Date: 2013-05-03 18:08:08
Message-ID: 5183FD08.9040307@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03.05.2013 20:56, Bruce Momjian wrote:
> On Fri, May 3, 2013 at 01:42:33PM -0400, Andrew Dunstan wrote:
>>
>> On 05/03/2013 01:23 PM, Bruce Momjian wrote:
>>> Not sure if I mentioned this, but having first line of the commit be a
>>> subject has save me lots of time in writing the release notes. I know
>>> it is helpful to others too who browse our commits on websites.
>>>
>>
>>
>> Yeah. The recommended style is to have the first line be 50 chars or
>> less, which is a bit unfortunate - it can be a challenge to keep to
>> that limit for a meaningful or comprehensive subject.
>
> Yes, I know mine are often cut-off. What I just did was to add a
> 50-character dashed line to the top of my editor window for commits so I
> can see the limit each time --- that should help me.

Oh, that's tight. I didn't know about the 50 char recommendation. I've
tried to keep mine < 76 chars, so that when you do "git log", it fits on
a 80 char display with the 4 char indentation that git log does.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2013-05-03 18:15:40 Re: Commit subject line
Previous Message Bruce Momjian 2013-05-03 17:56:40 Re: Commit subject line