From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Allow external recovery_config_directory |
Date: | 2013-03-27 16:24:28 |
Message-ID: | 51531D3C.70600@vmware.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 27.03.2013 18:10, Simon Riggs wrote:
> On 27 March 2013 15:35, Heikki Linnakangas<hlinnakangas(at)vmware(dot)com> wrote:
>> Ok, cool. Can you please revert this commit so that we can move on, then?
>
> Please explain why you want this reverted, without mentioning the
> other task we agree is required.
If an admin can't trust that the file is placed in $PGDATA, it's harder
to determine if a server is a master or a standby. It makes tools that
try to promote / demote a server more complicated, because they need to
take this setting into account. Lastly, it breaks the new pg_basebackup
-R functionality; pg_basebackup will create the recovery.conf file, but
it won't take effect.
From a process standpoint, this is a new feature that should've been
submitted before the commitfest deadline. I'm sure we'll make exceptions
to that every now and then, but by default new features should be bumped
to the next release at this point.
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2013-03-27 16:36:04 | pgsql: Set recovery_config_directory for EXEC_BACKEND. |
Previous Message | Heikki Linnakangas | 2013-03-27 16:20:26 | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2013-03-27 16:43:05 | Re: money with 4 digits after dot |
Previous Message | Heikki Linnakangas | 2013-03-27 16:20:26 | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |