| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Krishnakumar R <kksrcv001(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, byavuz81(at)gmail(dot)com |
| Subject: | Re: Add missing error codes to PANIC/FATAL error reports in xlogrecovery |
| Date: | 2023-11-30 21:02:55 |
| Message-ID: | 515167.1701378175@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> Wondering if we should add a ERRCODE_CLUSTER_CORRUPTED for cases like this. We
> have ERRCODE_DATA_CORRUPTED and ERRCODE_INDEX_CORRUPTED, which make
> ERRCODE_DATA_CORRUPTED feel a bit too specific in this kind of situation?
Maybe. We didn't officially define DATA_CORRUPTED as referring to
table data, but given the existence of INDEX_CORRUPTED maybe we
should treat it as that. In any case ...
> Hm, this one arguably is not corruption, but we still cannot
> continue. ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE or maybe a new error code?
... I don't really like turning a whole bunch of error cases into
the same error code without some closer analysis. I think you
are right that these need a bit more case-by-case thought.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-11-30 21:10:38 | Re: Add missing error codes to PANIC/FATAL error reports in xlogrecovery |
| Previous Message | Tristan Partin | 2023-11-30 21:00:22 | Re: meson: Stop using deprecated way getting path of files |