| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Limit usage of tcop/dest.h |
| Date: | 2005-11-02 14:20:15 |
| Message-ID: | 5150.1130941215@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> So instead of changing the names of the CommandDest enum, I'm hiding it
> from external view.
I thought renaming them was a better idea, actually. A whole separate
include file to have one forward typedef seems pretty silly. Nor am I
convinced that you won't break some people's code by removing the rest
of dest.h from spi.h. Finally, for anyone who *does* need to include
dest.h, this doesn't address the underlying problem of risk of conflict
of names.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2005-11-02 14:37:18 | Re: pg_restore [archiver] file offset in dump file is too |
| Previous Message | Tom Lane | 2005-11-02 14:16:25 | Re: PGXS on VPATH? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-11-02 14:49:50 | Re: tsearch2 makefile fixes |
| Previous Message | Alvaro Herrera | 2005-11-02 14:11:04 | Re: Limit usage of tcop/dest.h |