Re: hstore compiler warnings

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: hstore compiler warnings
Date: 2013-03-21 18:50:48
Message-ID: 514B5688.8090506@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 03/21/2013 11:18 AM, Andrew Dunstan wrote:
>
> On 03/21/2013 10:46 AM, Kevin Grittner wrote:
>> Is anyone looking at these?:
>>
>> hstore_io.c: In function ‘hstore_to_json_loose’:
>> hstore_io.c:1312:5: warning: ignoring return value of ‘strtol’,
>> declared with attribute warn_unused_result [-Wunused-result]
>> hstore_io.c:1324:6: warning: ignoring return value of ‘strtod’,
>> declared with attribute warn_unused_result [-Wunused-result]
>>
>> gcc (Ubuntu/Linaro 4.7.2-2ubuntu1) 4.7.2
>>
>> These warnings seem to have started with:
>>
>> http://git.postgresql.org/gitweb/?p=postgresql.git;h=38fb4d978c5bfc377ef979e2595e3472744a3b05
>>
>
>
> I thought we'd got rid of those. And they don't pop up on my F16 dev
> box (gcc 4.6.2)
>
> I'll check it out.

This is the only thing that I have found to work with very recent gcc.
Seems ugly. Anyone got a better idea?

cheers

andrew

Attachment Content-Type Size
unused-fix.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2013-03-21 18:53:15 Re: Should commit_delay be PGC_SIGHUP?
Previous Message Alvaro Herrera 2013-03-21 18:50:33 Re: Быстрые вклады с прибылью от 30% до 90% ежемесячно!