| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Thom Brown <thom(at)linux(dot)com> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix pg_dumpall with database names containing = |
| Date: | 2013-02-26 16:29:10 |
| Message-ID: | 512CE2D6.2010204@vmware.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 26.02.2013 18:03, Thom Brown wrote:
> On 20 February 2013 15:14, Heikki Linnakangas<heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>> Fix pg_dumpall with database names containing =
>>
>> If a database name contained a '=' character, pg_dumpall failed. The problem
>> was in the way pg_dumpall passes the database name to pg_dump on the
>> command line. If it contained a '=' character, pg_dump would interpret it
>> as a libpq connection string instead of a plain database name.
>>
>> To fix, pass the database name to pg_dump as a connection string,
>> "dbname=foo", with the database name escaped if necessary.
>>
>> Back-patch to all supported branches.
>
> I also notice that if you create a database with an "=" in, you can't
> connect to it using psql.
Specifying it as a connection string works:
psql dbname='8=8'
That's the same trick I applied to pg_dumpall's pg_dump invocations.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2013-02-26 17:33:44 | pgsql: Remove the check for COPY TO STDIN and COPY FROM STDOUT from ecp |
| Previous Message | Thom Brown | 2013-02-26 16:03:32 | Re: pgsql: Fix pg_dumpall with database names containing = |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-02-26 16:33:48 | Re: pg_xlogdump |
| Previous Message | Andres Freund | 2013-02-26 16:25:56 | Re: pg_xlogdump compile error |