From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Claudio Freire <klaussfreire(at)gmail(dot)com> |
Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Hari Babu <haribabu(dot)kommi(at)huawei(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Ants Aasma <ants(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit kapila <amit(dot)kapila(at)huawei(dot)com> |
Subject: | Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request) |
Date: | 2013-02-24 19:42:02 |
Message-ID: | 512A6D0A.2070304@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 02/24/2013 12:39 PM, Claudio Freire wrote:
> On Sun, Feb 24, 2013 at 11:08 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>> * Heikki Linnakangas (hlinnakangas(at)vmware(dot)com) wrote:
>>> So if you want to be kind to readers, look at the patch and choose
>>> the format depending on which one makes it look better. But there's
>>> no need to make a point of it when someone posts in "wrong" format.
>> To be more precise- my main complaint about this is that this patch is
>> making changes to multi-line comments and to documentation, both of
>> which get very annoying to try and read in uniform diff format.
>> Patches that don't do one or the other of those are likely incomplete
>> anyway.
>>
>> As another point, it's also the very first thing that we document in
>> http://wiki.postgresql.org/wiki/Reviewing_a_Patch to check for.
>
> TBH, that wiki link seems to suggest that *having context* is the
> point of the requirement (to be able to merge with fuzz).
>
> Both unified and context formats have context.
>
No, you're missing the point. Some people find reading context diffs
much easier than reading unified diffs. That's why context diffs are the
project's stated preference.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2013-02-24 20:08:33 | Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request) |
Previous Message | Claudio Freire | 2013-02-24 17:39:38 | Re: unified vs context diffs (was Re: Strange Windows problem, lock_timeout test request) |