Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition
Date: 2019-11-03 15:58:30
Message-ID: 5109.1572796710@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

ilmari(at)ilmari(dot)org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> I just noticed that when contrib/seg was converted to V1 calling
> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
> in terms of PG_GETARG_POINTER(). But it itself calls DatumGetPointer(),
> so shouldn't it be using PG_GETARG_DATUM()?

Yup, I agree. Pushed.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-11-03 16:12:15 Re: updating unaccent.rules for Arabic letters
Previous Message Dent John 2019-11-03 15:53:26 Re: The flinfo->fn_extra question, from me this time.