| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add function to import operating system collations |
| Date: | 2017-01-21 20:28:19 |
| Message-ID: | 5104.1485030499@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 1/21/17 12:50 PM, Tom Lane wrote:
>> I have to question the decision to make "no locales" a hard error.
>> What's the point of that? In fact, should we even be bothering with
>> a warning, considering how often initdb runs unattended these days?
> Hmm, it was a warning in initdb, so making it an error now is probably a
> mistake. We should change it back to a warning at least.
I'd drop it altogether I think ... it was useful debug back in the day
but now I doubt it is worth much.
> Also, if we add ICU initialization to this, then it's not clear how we
> would report if one provider provided zero locales but another did
> provide some.
Would it help to redefine the function as returning the number of locale
entries it successfully added?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-01-21 20:50:26 | pgsql: Add more includes so header files are self-contained |
| Previous Message | Tom Lane | 2017-01-21 20:18:41 | pgsql: Fix cross-shlib linking in temporary installs on HPUX 10. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-01-21 20:35:21 | Re: Failure in commit_ts tap tests |
| Previous Message | Greg Sabino Mullane | 2017-01-21 20:25:47 | Re: Checksums by default? |