| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Tid scan increments value of pg_stat_all_tables.seq_scan. (but not seq_tup_read) |
| Date: | 2020-01-29 14:24:09 |
| Message-ID: | 50c02735-1a25-ac97-c467-fb52ee844c50@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/01/29 20:06, Kasahara Tatsuhito wrote:
> Hi.
>
> Attached patch solve this problem.
>
> This patch adds table_beginscan_tid() and call it in TidListEval()
> instead of table_beginscan().
> table_beginscan_tid() is the same as table_beginscan() but do not set
> SO_TYPE_SEQSCAN to flags.
>
> Although I'm not sure this behavior is really problem or not,
> it seems to me that previous behavior is more prefer.
>
> Is it worth to apply to HEAD and v12 branch ?
I've not read the patch yet, but I agree that updating only seq_scan
but not seq_tup_read in Tid Scan sounds strange. IMO at least
both should be update together or neither should be updated.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
| From | Date | Subject | |
|---|---|---|---|
| Next Message | amul sul | 2020-01-29 14:47:49 | Re: closesocket behavior in different platforms |
| Previous Message | Fujii Masao | 2020-01-29 14:16:08 | pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side |