From: | dmp <danap(at)ttc-cmc(dot)net> |
---|---|
To: | Chen Huajun <chenhj(at)cn(dot)fujitsu(dot)com>, pgsql-jdbc(at)postgresql(dot)org |
Subject: | Re: [BUGS]log can not be output when use DataSource |
Date: | 2013-01-21 16:45:08 |
Message-ID: | 50FD7094.9050104@ttc-cmc.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
Chen,
Could you and possibly while considering the new possible bug you found with
copying DataSource do a more through review of the BaseDataSource class?
Then upon a review submit a complete patch to address not only the logLevel, but
any other issues you may find. In this way Dave may not have to deal with
this bug in a piecemeal fashion. You could also include with the complete
patch(s) the modification for Driver.NONE = 0 also, since I think you are
correct with this.
The reason I ask this is upon your discovery and my looking at that class
I suspect that some of the other parameters beside logLevel also have similar
problem. Also I think it best to deal with one issue at a time, so deal
with the original bug first, while considering the second then we can deal
with the copy/clone DataSource.
I think the patch you did send in today is the correct approach for logLevel.
Also a DataSource should in being cloned probably copy the current properties,
but that is only my first thought without review and full understanding.
danap.
From | Date | Subject | |
---|---|---|---|
Next Message | Chen Huajun | 2013-01-23 13:53:00 | Re: [BUGS]log can not be output when use DataSource |
Previous Message | Chen Huajun | 2013-01-21 12:42:07 | Re: [BUGS]log can not be output when use DataSource |