Re: [BUGS]log can not be output when use DataSource

> It's early here but I can't see how this makes it work. It appears that the code that is being replaced is exactly the same except that there is an if statement in front of it ?
>

> org.postgresql.Driver.setLogLevel(org.postgresql.Driver.DEBUG);

here the JVM level's LogLevel is set to be DEBUG.

> DataSource source = (DataSource)new InitialContext().lookup("DataSource");
> Connection con = source.getConnection();

source.getConnection()
-->DriverManager.getConnection(getUrl(), user, password)
->getUrl()
sb.append("&loglevel=").append(logLevel);

here the Connection's LogLevel is set to be the initial value 0(*) via URL,
although nobody set DataSource's LogLevel by calling BaseDataSource.setLogLevel().

I think it's better append "loglevel" to URL only when
BaseDataSource.setLogLevel() was called.
so a Connection created by DataSource.getConnection() can inherit JVM level's LogLevel setting
just like which one created by DriverManager.getConnection().

*)0 is the initial value and not a valid LogLevel,
valid values are INFO (1) and DEBUG (2).

--
Best Regards,
Chen Huajun
(2013/01/17 17:19), Dave Cramer wrote:
> It's early here but I can't see how this makes it work. It appears that the code that is being replaced is exactly the same except that there is an if statement in front of it ?
>
>
>
> Dave Cramer
>
> dave.cramer(at)credativ(dot)ca
> http://www.credativ.ca
>
>
> On Wed, Jan 16, 2013 at 11:47 PM, Chen Huajun <chenhj(at)cn(dot)fujitsu(dot)com <mailto:chenhj(at)cn(dot)fujitsu(dot)com>> wrote:
>
> Hi,
>
> In the following code,log can not be output as expected.
>
> -------------------------------------
> org.postgresql.Driver.setLogLevel(org.postgresql.Driver.DEBUG);
> DataSource source = (DataSource)new InitialContext().lookup("DataSource");
> Connection con = source.getConnection();
> -------------------------------------
>
> It's seems to be a problem,
> I have made a small patch to fix it.
> Hopefully this useful.
>
> --
> Best Regards,
> Chen Huajun
>
>
>
> --
> Sent via pgsql-jdbc mailing list (pgsql-jdbc(at)postgresql(dot)org <mailto:pgsql-jdbc(at)postgresql(dot)org>)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-jdbc
>
>