Re: Database object names and libpq in UTF-8 locale on Windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Sebastien FLAESCH <sf(at)4js(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Database object names and libpq in UTF-8 locale on Windows
Date: 2013-01-11 22:16:00
Message-ID: 50F08F20.2060105@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 11/21/2012 12:07 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 11/21/2012 11:11 AM, Tom Lane wrote:
>>> I'm not sure that's the only place we're doing this ...
>> Oh, Hmm, darn. Where else do you think we might?
> Dunno, but grepping for isupper and/or tolower should find any such
> places.
>
>

I've eliminated some false positives from the grep results. and here's a
list of list of the remaining files doing things that could be suspect.
Haven't had time to dig more.

src/backend/regex/regc_locale.c
src/backend/regex/regcomp.c
src/backend/regex/regc_pg_locale.c
src/backend/tsearch/ts_locale.c
src/backend/utils/adt/datetime.c
src/backend/utils/adt/formatting.c
src/backend/utils/adt/inet_net_pton.c
src/backend/utils/adt/like.c
src/backend/utils/misc/tzparser.c

I'd be tempted to say we should fix up the identifier issue regardless
of the rest, though.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Hellegers 2013-01-11 22:43:06 Re: Porting to Haiku
Previous Message Tom Lane 2013-01-11 21:49:31 Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)