Re: pgsql: Add mode where contrib installcheck runs each module in a separa

On 12/03/2012 01:45 PM, Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>> Add mode where contrib installcheck runs each module in a separately named database.
>>
>> Normally each module is tested in aq database named contrib_regression,
>> which is dropped and recreated at the beginhning of each pg_regress run.
>> This mode, enabled by adding USE_MODULE_DB=1 to the make command line,
>> runs most modules in a database with the module name embedded in it.
> I'm seeing this when building contrib/dblink:
>
> $ LC_ALL=C make
> Makefile:15: invalid `override' directive
>
> $ LC_ALL=C !!
> LC_ALL=C make --version
> GNU Make 3.81
> Copyright (C) 2006 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.
> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
> PARTICULAR PURPOSE.
>
> This program built for x86_64-pc-linux-gnu
>
>
> It doesn't work (note the DB name in the command line):
>
> $ LC_ALL=C make USE_MODULE_DB=q installcheck
> Makefile:15: invalid `override' directive
> make -C ../../src/test/regress pg_regress
> make[1]: Entering directory `/home/alvherre/Code/pgsql/build/bgworker/src/test/regress'
> make -C ../../../src/port all
> make[2]: Entering directory `/home/alvherre/Code/pgsql/build/bgworker/src/port'
> make -C ../backend submake-errcodes
> make[3]: Entering directory `/home/alvherre/Code/pgsql/build/bgworker/src/backend'
> make[3]: Nothing to be done for `submake-errcodes'.
> make[3]: Leaving directory `/home/alvherre/Code/pgsql/build/bgworker/src/backend'
> make[2]: Leaving directory `/home/alvherre/Code/pgsql/build/bgworker/src/port'
> make[1]: Leaving directory `/home/alvherre/Code/pgsql/build/bgworker/src/test/regress'
> ../../src/test/regress/pg_regress --inputdir=/pgsql/source/bgworker/contrib/dblink --psqldir='/pgsql/install/bgworker/bin' --dbname=contrib_regression_dblink dblink
> (using postmaster on Unix socket, default port)
> ============== dropping database "contrib_regression_dblink" ==============
> psql: could not connect to server: No such file or directory
> Is the server running locally and accepting
> connections on Unix domain socket "/tmp/.s.PGSQL.55440"?
> command failed: "/pgsql/install/bgworker/bin/psql" -X -c "DROP DATABASE IF EXISTS \"contrib_regression_dblink\"" "postgres"
> make: *** [installcheck] Error 2
>

Well, you seem to have more problems than just the database name.

This seems rather odd, though. What more can you tell us about the
platform etc.? I note you have "USE_MODULE_DB=q" where I'm using
"USE_MODULE_DB=1". Do you get the same failure when you don't define
USE_MODULE_DB?

cheers

andrew