| From: | Chen Huajun <chenhj(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: fix ecpg core dump when there's a very long struct variable name in .pgc file |
| Date: | 2012-11-25 12:02:33 |
| Message-ID: | 50B208D9.4060106@cn.fujitsu.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> How on earth did you run into this? :)
ooh, first I saw the code accidentally,it looks a bit dangerous and differents from the function ECPGdump_a_simple() above,
And then I tried to write a test to raise some errors.
Thanks for your comment,I will add the patch into commitfest later.
It maybe my first patch for open source.
And I am glad if I can do more for PostgreSQL which is so fine.:)
Regards,
Chen Huajun
(2012/11/23 21:42), Michael Meskes wrote:
> On Thu, Nov 22, 2012 at 06:09:20PM +0800, Chen Huajun wrote:
>> When use a struct variable whose name length is very very long such as 12KB in .pgc source,
>> ecpg will core dump because of buffer overflow if precompile the .pgc file.
>
> How on earth did you run into this? :)
>
> I absolutely agree that this is better be fixed and cjust committed the second
> version of your patch.
>
> Thanks.
>
> Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2012-11-25 14:18:24 | Re: fix ecpg core dump when there's a very long struct variable name in .pgc file |
| Previous Message | Jeff Janes | 2012-11-25 05:51:30 | autovacuum stats under log_autovacuum_min_duration |