| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [BUG] False indication in pg_stat_replication.sync_state |
| Date: | 2012-11-23 18:00:33 |
| Message-ID: | 50AFB9C1.5000806@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23.11.2012 19:55, Tom Lane wrote:
> Heikki Linnakangas<hlinnakangas(at)vmware(dot)com> writes:
>> Committed, thanks.
>
> Doesn't seem to have been pushed to master?
On purpose. Per commit message:
> 9.3 doesn't have this problem because XLogRecPtr is now a single 64-bit
> integer, so XLogRecPtrIsInvalid() does the right thing. Apply to 9.2, and
> 9.1 where pg_stat_replication view was introduced.
I considered applying it to master anyway, just to keep the branches in
sync. But XLogRecPtrIsInvalid(var) seems slightly more readable than
XLByteEQ(var, InvalidXLogRecPtr), so I decided not to.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Kupershmidt | 2012-11-23 19:54:43 | Re: Suggestion for --truncate-tables to pg_restore |
| Previous Message | Tom Lane | 2012-11-23 17:55:08 | Re: [BUG] False indication in pg_stat_replication.sync_state |