From: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Make pg_basebackup configure and start standby [Review] |
Date: | 2012-11-20 19:32:56 |
Message-ID: | 50ABDAE8.2000205@cybertec.at |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2012-11-20 17:03 keltezéssel, Boszormenyi Zoltan írta:
> 2012-11-18 17:20 keltezéssel, Magnus Hagander írta:
>
>> Much of the tar stuff is very similar (I haven't looked to see if it's
>> identical) to the stuff in backend/replication/basebackup.c. Perhaps
>> we should have a src/port/tarutil.c?
>
> I will implement it as a separate patch.
I implemented it, all 3 patches are attached now. Use this patchset,
the previously sent 1st patch had a bug, it called conninit_storeval()
with value == NULL arguments and it crashes on strdup(NULL).
>
>> escape_string() - already exists as escape_quotes() in initdb, AFAICT.
>> We should either move it to src/port/, or at least copy it so it's
>> exactly the same.
>
> A copy of escape_quotes() is now in pg_basebackup.c and is used.
>
> I will also unify the copies of it in a separate patch.
This one is not done yet, but a suggestion on which existing file
it can fit into or for a new src/port/filename is welcome.
Best regards,
Zoltán Böszörményi
--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/
Attachment | Content-Type | Size |
---|---|---|
01-PQconninfo-v16.patch | text/x-patch | 15.8 KB |
02-pg_basebackup-v16.patch | text/x-patch | 20.3 KB |
03-tarutils.patch | text/x-patch | 18.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-11-20 19:44:26 | Re: review: Reduce palloc's in numeric operations |
Previous Message | Andres Freund | 2012-11-20 19:29:37 | Re: [PATCH] binary heap implementation |